Skip to content

Adding vectordb modules under infra/base #136

Open
senkinnar wants to merge 1 commit intoawslabs:mainfrom
senkinnar:vectordb
Open

Adding vectordb modules under infra/base #136
senkinnar wants to merge 1 commit intoawslabs:mainfrom
senkinnar:vectordb

Conversation

@senkinnar
Copy link

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction. When we triage the issues, we will add labels to the issue like "Enhancement", "Bug" which should indicate to you that this issue can be worked on and we are looking forward to your PR. We would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Adding Milvus, Qdrant, and Weaviate implementation under infra/base and infra/vectordb using ArgoCD
Adding Graviton nodepools
Modifying website and other files as required

Motivation

VectorDB is essential for running AI implementation patterns such as RAG and Agentic AI applications as a knowledge base. This will provide reusable implementations that run on AWS Graviton to deliver price-performance benefits.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Contributor

@omrishiv omrishiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @senkinnar thanks for the contribution! It's great to get some vectordb infrastructure. A few small things to start with. Thanks!

automated:
prune: true
selfHeal: true
managedNamespaceMetadata:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dowe need all of these tracking annotations? ArgoCD should add them by default

name: milvus
namespace: argocd
finalizers:
- resources-finalizer.argocd.argoproj.io/background
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this used for?

automated:
prune: true
selfHeal: true
managedNamespaceMetadata:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all of these tracking annotations? ArgoCD should add them by default

annotations:
argocd.argoproj.io/tracking-id: >-
qdrant:/qdrant:qdrant/qdrant

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many newlines

enable_tls: false
consensus:
tick_period_ms: 100
# In production scenario apiKey should be set for Authentication, an external secret can be used here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a link we can include here?

annotations:
argocd.argoproj.io/tracking-id: >-
weaviate:/weaviate:weaviate/weaviate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many new lines

count = var.enable_vectordb_qdrant ? 1 : 0
yaml_body = file("${path.module}/argocd-addons/vectordb-qdrant-helm.yaml")
depends_on = [module.eks_blueprints_addons]
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a newline

description = "Enable Qdrant Milvus"
type = bool
default = false
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

@@ -0,0 +1,29 @@
name = "vectordb-on-eks"
enable_vectordb_milvus = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix alignment

@@ -0,0 +1,348 @@
# VectorDB Examples
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is demonstrating infrastructure, it should move to website/docs/infra/ai-ml/vectordbs.md as a docusaurus markdown (please look at some of the other pages for examples. You can then fold milvus_distributed.yaml into the page using collapsible content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants