Adding vectordb modules under infra/base #136
Conversation
omrishiv
left a comment
There was a problem hiding this comment.
Hi @senkinnar thanks for the contribution! It's great to get some vectordb infrastructure. A few small things to start with. Thanks!
| automated: | ||
| prune: true | ||
| selfHeal: true | ||
| managedNamespaceMetadata: |
There was a problem hiding this comment.
Dowe need all of these tracking annotations? ArgoCD should add them by default
| name: milvus | ||
| namespace: argocd | ||
| finalizers: | ||
| - resources-finalizer.argocd.argoproj.io/background |
| automated: | ||
| prune: true | ||
| selfHeal: true | ||
| managedNamespaceMetadata: |
There was a problem hiding this comment.
Do we need all of these tracking annotations? ArgoCD should add them by default
| annotations: | ||
| argocd.argoproj.io/tracking-id: >- | ||
| qdrant:/qdrant:qdrant/qdrant | ||
|
|
| enable_tls: false | ||
| consensus: | ||
| tick_period_ms: 100 | ||
| # In production scenario apiKey should be set for Authentication, an external secret can be used here |
There was a problem hiding this comment.
Is there a link we can include here?
| annotations: | ||
| argocd.argoproj.io/tracking-id: >- | ||
| weaviate:/weaviate:weaviate/weaviate | ||
|
|
| count = var.enable_vectordb_qdrant ? 1 : 0 | ||
| yaml_body = file("${path.module}/argocd-addons/vectordb-qdrant-helm.yaml") | ||
| depends_on = [module.eks_blueprints_addons] | ||
| } No newline at end of file |
| description = "Enable Qdrant Milvus" | ||
| type = bool | ||
| default = false | ||
| } No newline at end of file |
| @@ -0,0 +1,29 @@ | |||
| name = "vectordb-on-eks" | |||
| enable_vectordb_milvus = false | |||
| @@ -0,0 +1,348 @@ | |||
| # VectorDB Examples | |||
There was a problem hiding this comment.
As this is demonstrating infrastructure, it should move to website/docs/infra/ai-ml/vectordbs.md as a docusaurus markdown (please look at some of the other pages for examples. You can then fold milvus_distributed.yaml into the page using collapsible content
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction. When we triage the issues, we will add labels to the issue like "Enhancement", "Bug" which should indicate to you that this issue can be worked on and we are looking forward to your PR. We would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Adding Milvus, Qdrant, and Weaviate implementation under infra/base and infra/vectordb using ArgoCD
Adding Graviton nodepools
Modifying website and other files as required
Motivation
VectorDB is essential for running AI implementation patterns such as RAG and Agentic AI applications as a knowledge base. This will provide reusable implementations that run on AWS Graviton to deliver price-performance benefits.
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes