fix: add quality-target verification gate to Construction phase#274
Open
Mameta29 wants to merge 3 commits into
Open
fix: add quality-target verification gate to Construction phase#274Mameta29 wants to merge 3 commits into
Mameta29 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #273.
Adds a tool-agnostic quality-target verification gate to the Construction phase. Measurable quality targets defined in NFR Requirements (test coverage thresholds, performance budgets, etc.) currently have no downstream stage that verifies they were met — an agent can silently miss, or even lower, its own defined target while satisfying every rule. This PR closes that gap with three minimal changes.
Changes
construction/code-generation.mdHONOR QUALITY TARGETSto the "Generation Phase Rules" Critical Rulesconstruction/build-and-test.mdcommon/overconfidence-prevention.mdRationale
This mirrors the gap PR #155 fixed for question/answer rigor: a property is strengthened on one side of a stage boundary but left unenforced on the other. Here, quality targets are defined (NFR Requirements) but never verified (Code Generation / Build & Test). The change is consistent with
common/overconfidence-prevention.md's principle of not proceeding past unresolved gaps.The changes are tool-agnostic (no test-runner-specific wording) and follow the "single source of truth" principle —
overconfidence-prevention.mdcarries the red flag, the stage files carry the actionable rules.Test Plan
markdownlint-cli2(0 errors).Checklist
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.