fix: scope per-unit artifact loading to unit directories in session-continuity#276
Open
Mameta29 wants to merge 1 commit into
Open
fix: scope per-unit artifact loading to unit directories in session-continuity#276Mameta29 wants to merge 1 commit into
Mameta29 wants to merge 1 commit into
Conversation
This was referenced May 17, 2026
harmjeff
approved these changes
May 18, 2026
Contributor
harmjeff
left a comment
There was a problem hiding this comment.
LGTM! Clean, well-scoped fix for a real bug that hits multi-unit Construction projects on session resume.
Good approach — referencing the construction stage rules as the source of truth for exact filenames rather than duplicating a stale list here. The unit selection logic (check aidlc-state.md + load dependencies per unit-of-work-dependency.md) is correct and actionable for an agent resuming with zero context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #275.
The "Per-Unit Design" artifact-loading instruction in
session-continuity.mddid not reflect the actual per-unit directory structure of the Construction phase. A resumed, zero-context session had no way to know which unit's artifacts to load or where they live.Problem
session-continuity.mdline 33 read:This is inaccurate in three ways (verified against the current rule files):
{unit-name}directory level. Every Construction stage writes toaidlc-docs/construction/{unit-name}/{stage}/(e.g.functional-design.mdlines 68-71). The line listed bare filenames with no path.functional-design.md— the stage producesfunctional-design/business-logic-model.md,business-rules.md,domain-entities.md; similarly fornfr-designandnfr-requirements.The other lines in the same list are fine because those stages are not unit-scoped — only Per-Unit Design has artifacts under a
{unit-name}directory.Change
Rewrites the Per-Unit Design line to:
aidlc-docs/construction/{unit-name}/{functional-design,nfr-requirements,nfr-design,infrastructure-design}/.aidlc-state.md, load that unit plus its dependencies (perunit-of-work-dependency.md).Test Plan
markdownlint-cli2(0 errors).Checklist
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.