fix: add [next-stage-name] substitution guidance for construction app…#440
Open
dferguson992 wants to merge 2 commits into
Open
fix: add [next-stage-name] substitution guidance for construction app…#440dferguson992 wants to merge 2 commits into
dferguson992 wants to merge 2 commits into
Conversation
Author
|
@awslabs/aidlc-admins PR is ready to go, idk what is causing the gitleaks failure. I can't reproduce locally with Kiro. |
Author
|
@awslabs/aidlc-admins Just flagging this up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…roval messages (#406)
Summary
During the Construction phase, the approval messages after Functional Design, NFR Requirements, and NFR Design always display "Continue to Code Generation" regardless of which stage just completed. The
[next-stage-name]placeholder in the completion message template has no guidance telling the AI model what to substitute, so it defaults to the most prominent terminal stage.Three construction stage files use
[next-stage-name]as a placeholder in their Step 7 completion message, but provide no instruction on how to resolve it. Meanwhile,infrastructure-design.mdalready hardcodes "Code Generation" (correctly, since it's always the next stage after infrastructure design). The other files lack equivalent guidance, causing the AI to guess incorrectly.Changes
Added a
[next-stage-name] substitutioninstruction block to each affected file, specifying the Construction phase stage ordering and directing the AI to checkaidlc-docs/aidlc-state.mdfor which stages are enabled:functional-design.mdnfr-requirements.mdnfr-design.mdThis preserves the adaptive/conditional nature of the workflow (stages can be skipped) while eliminating ambiguity.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Test Plan
Tested in Kiro IDE 1.0.0 (macOS) with a complex multi-unit project request. Verified all four approval gates now display the correct next stage:
Previously, all three intermediate stages incorrectly displayed "Code Generation" as reported in #406.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.