fix: baselining error handling - #370
Merged
kukushking merged 3 commits intoDec 1, 2025
Merged
Conversation
kukushking
marked this pull request as ready for review
November 28, 2025 16:54
EthanBunce
approved these changes
Dec 1, 2025
| if status == "Completed": | ||
| logger.info(f"Job {job_name} completed successfully") | ||
| return {"statusCode": 200, "job_name": job_name, "status": "COMPLETED"} | ||
| elif status in ["Failed", "Stopped", "Stopping"]: |
Contributor
There was a problem hiding this comment.
Are there any cases where we would want to differentiate between stopped and failed? Or at least return the original status?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before requesting a review
CHANGELOG.MDwith a description of my changesscripts/validate.sh)seedfarmer applyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.