Dual-Stack Endpoints#431
Merged
stefankiesz merged 11 commits intodualstack-release-v2.4.5from Dec 19, 2025
Merged
Conversation
sirknightj
reviewed
Mar 26, 2025
stefankiesz
changed the title
sirknightj
reviewed
Apr 23, 2025
sirknightj
previously approved these changes
Apr 24, 2025
unicornss
previously approved these changes
Apr 25, 2025
stefankiesz
force-pushed
the
dual-stack-support
branch
from
8e50391 to
4facb6c
Compare
stefankiesz
dismissed stale reviews from unicornss and sirknightj
The base branch was changed.
stefankiesz
force-pushed
the
dual-stack-support
branch
from
8add1f4 to
4a8a3f2
Compare
GrifKies
reviewed
Dec 17, 2025
| @@ -351,7 +352,11 @@ async function getIceServersWithCaching(formValues) { | |||
|
|
|||
| // Add the STUN server unless it is disabled | |||
| if (!formValues.natTraversalDisabled && !formValues.forceTURN && formValues.sendSrflxCandidates) { | |||
There was a problem hiding this comment.
Would it be possible to add something for GovCloud STUN since those domain names will have -fips in them?
Something like this?
if (!formValues.natTraversalDisabled && !formValues.forceTURN && formValues.sendSrflxCandidates) {
let fipsSuffix = formValues.region.includes("gov" ) ? "-fips" : "";
iceServers.push({ urls: `stun:stun.kinesisvideo.${formValues.region}.amazonaws.com:443` });
if (formValues.useDualStackEndpoints) {
iceServers.push({ urls: `stun:stun.kinesisvideo${fipsSuffix}.${formValues.region}.api.aws:443` });
} else {
iceServers.push({ urls: `stun:stun.kinesisvideo${fipsSuffix}.${formValues.region}.amazonaws.com:443` });
}
}
Contributor
Author
There was a problem hiding this comment.
Hi Griffin, we will look into this for a future release, but this will not be in scope for the upcoming release.
stefankiesz
changed the title
stefankiesz
changed the base branch from
release-v2.4.5
to
copy-release-v2.4.5
stefankiesz
changed the base branch from
copy-release-v2.4.5
to
dualstack-release-v2.4.5
stefankiesz
added a commit
that referenced
this pull request
Dec 19, 2025
* Add check-box field for controlling dual-stack endpoint mode * Space out header top margins * Update info message * Change input field to a switch, reposition it * Revert redundant change * Add dual-stack stun endpoint * Update UI of dual-stack control * Fix custom endpoint with dualStack enabled case * Update the customEndpoint unset value * Dualstack fix * Dualstack endpoint update
Merged
stefankiesz
added a commit
that referenced
this pull request
Dec 20, 2025
* Dual-Stack Endpoints (#431) * Add check-box field for controlling dual-stack endpoint mode * Space out header top margins * Update info message * Change input field to a switch, reposition it * Revert redundant change * Add dual-stack stun endpoint * Update UI of dual-stack control * Fix custom endpoint with dualStack enabled case * Update the customEndpoint unset value * Dualstack fix * Dualstack endpoint update * Address comment
stefankiesz
added a commit
that referenced
this pull request
Dec 22, 2025
* Change URL for fetching regional data (#674) * Fix undefined channelHelper check (#675) * Migrate to OIDC trusted publishing (#676) * Dualstack endpoints (#682) * Dual-Stack Endpoints (#431) * Add check-box field for controlling dual-stack endpoint mode * Space out header top margins * Update info message * Change input field to a switch, reposition it * Revert redundant change * Add dual-stack stun endpoint * Update UI of dual-stack control * Fix custom endpoint with dualStack enabled case * Update the customEndpoint unset value * Dualstack fix * Dualstack endpoint update * Address comment * Bump version to 2.5.0 in package.json (#683) * Bump version to 2.5.0 in package.json * Update package-lock --------- Co-authored-by: sirknightj <jggunawa@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
useDualStackEndpointsparameter ofAWS.KinesisVideoclient instances.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.