Skip to content

Samples: Add the loadedData event listener only once #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirknightj merged 1 commit into from
Apr 10, 2025
Merged

Samples: Add the loadedData event listener only once #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions examples/viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,24 +268,25 @@ async function startViewer(localView, remoteView, formValues, onStatsReport, rem
viewer.localView = localView;
viewer.remoteView = remoteView;

viewer.remoteView.addEventListener('loadeddata', () => {
viewer.loadedDataCallback = () => {
metrics.viewer.ttff.endTime = Date.now();
if (formValues.enableProfileTimeline) {
metrics.viewer.ttffAfterPc.endTime = metrics.viewer.ttff.endTime;
metrics.master.ttffAfterPc.endTime = metrics.viewer.ttff.endTime;


// if the ice-gathering on the master side is not complete by the time the metrics are sent, the endTime > startTime
// in order to plot it, we can show it as an ongoing process
if (metrics.master.iceGathering.startTime > metrics.master.iceGathering.endTime) {
metrics.master.iceGathering.endTime = metrics.viewer.ttff.endTime;
}
}
if(formValues.enableDQPmetrics) {
if (formValues.enableDQPmetrics) {
timeToFirstFrameFromOffer = metrics.viewer.ttff.endTime - metrics.viewer.offAnswerTime.startTime;
timeToFirstFrameFromViewerStart = metrics.viewer.ttff.endTime - viewerButtonPressed.getTime();
}
});
};

viewer.remoteView.addEventListener('loadeddata', viewer.loadedDataCallback);

if (formValues.enableProfileTimeline) {
metrics.viewer.ttff.startTime = viewerButtonPressed.getTime();
Expand Down Expand Up @@ -818,6 +819,7 @@ function stopViewer() {
}

if (viewer.remoteView) {
viewer.remoteView.removeEventListener('loadeddata');
viewer.remoteView.srcObject = null;
}

Expand Down