Case resolver jdbc #2655
Open
Case resolver jdbc #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2655 +/- ##
============================================
+ Coverage 60.68% 60.90% +0.22%
- Complexity 3871 3891 +20
============================================
Files 593 602 +9
Lines 22130 21928 -202
Branches 2732 2702 -30
============================================
- Hits 13430 13356 -74
+ Misses 7398 7263 -135
- Partials 1302 1309 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chngpe
force-pushed
the
case_resolver_jdbc
branch
from
7e81c5e to
d9df3ef
Compare
… to expand search capabilities only need to provide information schema query -Clean up duplication code. -Introduce case resolver to FederationSDK -Introduce Default JDBC case resolver for JDBC connectors. If we want to expand search capabilities only need to provide information schema query -Clean up duplication code. -Fix pagination token, return null when empty or last records. Standardize Case resolver support for below JDBC connectors: 1. DataLakeGen2 2. Snowflake 3. Oracle 4. Synapse 5. SapHana 6. MySQL 7. PostGreSql 9. ClickHouse uncomment pom
… mixed cased fix checkstyle
…per case object with casing_mode = CASE_SENSITIVE_SEARCH
chngpe
force-pushed
the
case_resolver_jdbc
branch
from
d9df3ef to
ac0155f
Compare
aimethed
reviewed
Mar 20, 2025
| LOWER, // casing mode to lower case everything (glue and trino lower case everything) | ||
| UPPER, // casing mode to upper case everything (oracle by default upper cases everything) | ||
| CASE_INSENSITIVE_SEARCH, // | ||
| ANNOTATION |
There was a problem hiding this comment.
nit: finish comments here for other two modes
| private static final Logger LOGGER = LoggerFactory.getLogger(PostGreSqlJDBCCaseResolver.class); | ||
| private static final String SCHEMA_NAME_QUERY_TEMPLATE = "SELECT schema_name FROM information_schema.schemata WHERE lower(schema_name) = ?"; | ||
| private static final String TABLE_NAME_QUERY_TEMPLATE = "SELECT table_name FROM information_schema.tables WHERE table_schema = ? AND lower(table_name) = ?"; | ||
| private static final String TABLE_NAME_QUERY_MATERIALIZED_VIEW = "select matviewname as \"table_name\" from pg_catalog.pg_matviews mv where schemaname = ? and lower(matviewname) = ?"; |
There was a problem hiding this comment.
nit: SQL keywords are lower case for this but uppercase for other queries
| private static final Logger LOGGER = LoggerFactory.getLogger(RedshiftJDBCCaseResolver.class); | ||
| private static final String SCHEMA_NAME_QUERY_TEMPLATE = "SELECT nspname FROM pg_namespace WHERE lower(nspname) = ?"; | ||
| private static final String TABLE_NAME_QUERY_TEMPLATE = "SELECT table_name FROM information_schema.tables WHERE table_schema = ? AND lower(table_name) = ?"; | ||
| private static final String TABLE_NAME_QUERY_EXTERNAL_TABLE = "SELECT tablename as \"table_name\" FROM svv_external_tables where schemaname = ? and lower(tablename) = ?"; |
There was a problem hiding this comment.
lower(tablename) should be lower(table_name) right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.