Skip to content

Case resolver jdbc #2655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 31, 2025
Merged

Case resolver jdbc #2655

merged 8 commits into from
Mar 31, 2025

Conversation

chngpe
Copy link
Contributor

@chngpe chngpe commented Mar 14, 2025

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 49.69880% with 167 lines in your changes missing coverage. Please review.

Project coverage is 60.88%. Comparing base (f3521ad) to head (64f94c2).
Report is 154 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ena/connectors/jdbc/resolver/JDBCCaseResolver.java 55.69% 28 Missing and 7 partials ⚠️
...nectors/jdbc/resolver/DefaultJDBCCaseResolver.java 23.07% 30 Missing ⚠️
...athena/connector/lambda/resolver/CaseResolver.java 0.00% 24 Missing ⚠️
.../jdbc/connection/GenericJdbcConnectionFactory.java 0.00% 12 Missing ⚠️
...nnectors/postgresql/PostGreSqlMetadataHandler.java 60.00% 7 Missing and 1 partial ⚠️
...ena/connectors/redshift/RedshiftRecordHandler.java 0.00% 8 Missing ⚠️
...a/connectors/jdbc/manager/JdbcMetadataHandler.java 69.56% 7 Missing ⚠️
...lickhouse/resolver/ClickhouseJDBCCaseResolver.java 42.85% 4 Missing ⚠️
...atalakegen2/resolver/DataLakeGen2CaseResolver.java 42.85% 4 Missing ⚠️
.../athena/connectors/mysql/MySqlMetadataHandler.java 20.00% 3 Missing and 1 partial ⚠️
... and 12 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2655      +/-   ##
============================================
+ Coverage     60.68%   60.88%   +0.20%     
- Complexity     3871     3897      +26     
============================================
  Files           593      602       +9     
  Lines         22130    21991     -139     
  Branches       2732     2707      -25     
============================================
- Hits          13430    13390      -40     
+ Misses         7398     7288     -110     
- Partials       1302     1313      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chngpe and others added 7 commits March 31, 2025 13:03
… to expand search capabilities only need to provide information schema query

-Clean up duplication code.

-Introduce case resolver to FederationSDK
-Introduce Default JDBC case resolver for JDBC connectors. If we want to expand search capabilities only need to provide information schema query
-Clean up duplication code.
-Fix pagination token, return null when empty or last records.

Standardize Case resolver support for below JDBC connectors:
1. DataLakeGen2
2. Snowflake
3. Oracle
4. Synapse
5. SapHana
6. MySQL
7. PostGreSql
9. ClickHouse

uncomment pom
…per case object with casing_mode = CASE_SENSITIVE_SEARCH
@chngpe chngpe force-pushed the case_resolver_jdbc branch from 01d42a0 to ef1e148 Compare March 31, 2025 17:49
@chngpe chngpe force-pushed the case_resolver_jdbc branch from ef1e148 to 64f94c2 Compare March 31, 2025 18:21
@chngpe chngpe merged commit e03dd42 into master Mar 31, 2025
10 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 8, 2025
  - Error handling changes for Elasticsearch connector (#2279)
  - build(deps): bump aws-sdk-v2.version from 2.31.14 to 2.31.16 (#2709)
  - build(deps): bump net.snowflake:snowflake-jdbc from 3.23.1 to 3.23.2 (#2710)
  - build(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.19.2 to 3.19.3 (#2712)
  - build(deps): bump net.sf.jt400:jt400 from 21.0.0 to 21.0.3 (#2711)
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs from 2.31.14 to 2.31.16 (#2708)
  - build(deps): bump com.sap.cloud.db.jdbc:ngdbc from 2.24.6 to 2.24.7 (#2707)
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs from 2.31.11 to 2.31.14 (#2704)
  - build(deps): bump org.jacoco:jacoco-maven-plugin from 0.8.12 to 0.8.13 (#2703)
  - build(deps): bump com.zaxxer:HikariCP from 6.2.1 to 6.3.0 (#2706)
  - build(deps): bump software.amazon.jsii:jsii-runtime from 1.110.0 to 1.111.0 (#2705)
  - build(deps): bump aws-sdk-v2.version from 2.31.11 to 2.31.14 (#2702)
  - Explicitly ignore dependency updates in validation_testing (#2701)
  - Revert "build(deps): bump aws-cdk-lib from 2.177.0 to 2.186.0 in /val… (#2700)
  - Updated rds truststore to default truststore for oracle and docdb. (#2698)
  - build(deps): bump aws-cdk-lib from 2.177.0 to 2.186.0 in /validation_testing/cdk_federation_infra_provisioning/app (#2697)
  - Case resolver jdbc (#2655)
  - build(deps): bump org.elasticsearch.client:elasticsearch-rest-client from 8.17.3 to 8.17.4 (#2695)
  - build(deps): bump surefire.failsafe.version from 3.5.2 to 3.5.3 (#2693)
  - build(deps): bump software.amazon.awssdk:cloudwatchlogs from 2.31.6 to 2.31.11 (#2696)
  - build(deps): bump org.junit.support:testng-engine from 1.0.5 to 1.0.6 (#2692)
  - build(deps): bump aws-sdk-v2.version from 2.31.6 to 2.31.11 (#2691)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants