Skip to content

Avoid nullptr dereference in sts creds provider client #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SergeyRyabinin wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Avoid nullptr dereference in sts creds provider client #173

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8576d9a
Avoid nullptr dereference in sts creds provider client
SergeyRyabinin Sep 6, 2022
1e59699
CR comments on nullptr deref
SergeyRyabinin Apr 22, 2024
499c895
Merge branch 'main' into sr/stsnull
jmklix Apr 22, 2024
8625bca
clang-format
SergeyRyabinin Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions source/credentials_provider_sts.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,10 @@ void s_on_signing_complete(struct aws_signing_result *result, int error_code, vo
static void s_start_make_request(
struct aws_credentials_provider *provider,
struct sts_creds_provider_user_data *provider_user_data) {
if (!provider_user_data) {
goto error;
}

provider_user_data->message = aws_http_message_new_request(provider->allocator);

if (!provider_user_data->message) {
Expand Down Expand Up @@ -553,12 +557,10 @@ static void s_start_make_request(
AWS_LOGF_ERROR(
AWS_LS_AUTH_CREDENTIALS_PROVIDER,
"(id=%p): error occurred while creating an http request for signing: %s",
(void *)provider_user_data->provider,
provider_user_data ? (void *)provider_user_data->provider : NULL,
aws_error_debug_str(aws_last_error()));
if (provider_user_data) {
s_clean_up_user_data(provider_user_data);
} else {
provider_user_data->callback(NULL, provider_user_data->error_code, provider_user_data->user_data);
}
}

Expand Down