Add proxy settings for profile credentials provider #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Krish <>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 81.93% 81.95% +0.01%
==========================================
Files 36 36
Lines 7065 7067 +2
==========================================
+ Hits 5789 5792 +3
+ Misses 1276 1275 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TingDaoK
reviewed
Dec 17, 2025
Comment on lines
380
to
386
| struct aws_credentials_provider_imds_options imds_options = { | ||
| .bootstrap = options->bootstrap, | ||
| .function_table = options->function_table, | ||
| }; | ||
|
|
||
| struct aws_credentials_provider *imds_provider = | ||
| aws_credentials_provider_new_imds(allocator, &imds_options); |
Contributor
There was a problem hiding this comment.
do we need the proxy passed down to here as well?
Comment on lines
415
to
424
| struct aws_credentials_provider_ecs_environment_options ecs_options = { | ||
| .bootstrap = options->bootstrap, | ||
| .function_table = options->function_table, | ||
| .tls_ctx = tls_ctx, | ||
| }; | ||
| struct aws_credentials_provider *ecs_provider = | ||
| aws_credentials_provider_new_ecs_from_environment(allocator, &ecs_options); | ||
| if (!ecs_provider) { | ||
| goto done; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.