Skip to content

Fail http proxy configuration when using SecItem #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiazhvera merged 11 commits into from
Mar 2, 2026
Merged

Fail http proxy configuration when using SecItem #551

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
69fbb57
testing ios validation
xiazhvera Feb 20, 2026
31e50d5
update validate_proxy_configuration
xiazhvera Feb 23, 2026
dbab6a9
add on secitem
xiazhvera Feb 24, 2026
1b50693
fail http proxy if use secitem
xiazhvera Feb 24, 2026
ee0a808
update error message
xiazhvera Feb 24, 2026
8b5f98b
use build flag instead
xiazhvera Feb 24, 2026
b1185bf
remove unused dependency
xiazhvera Feb 24, 2026
c008a55
remove aws_os_apple
xiazhvera Feb 25, 2026
a006de6
move proxy check to aws_http_proxy_new_socket_channel
xiazhvera Feb 26, 2026
043c0d7
remove valiadtion fron http client
xiazhvera Feb 26, 2026
e9cdaa4
clean up
xiazhvera Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions source/connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,6 +1057,14 @@ int aws_http_client_connect_internal(
AWS_LOGF_ERROR(AWS_LS_HTTP_CONNECTION, "static: http connection options are null.");
return aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
}

#if defined(AWS_USE_SECITEM) && defined(AWS_OS_APPLE)
Comment thread
xiazhvera marked this conversation as resolved.
Outdated
if (proxy_request_transform) {
AWS_LOGF_ERROR(AWS_LS_HTTP_PROXY_NEGOTIATION, "HTTP proxy is not supported on Apple Network Framework.");
return aws_raise_error(AWS_ERROR_PLATFORM_NOT_SUPPORTED);
}
#endif

struct aws_http_client_bootstrap *http_bootstrap = NULL;
struct aws_string *host_name = NULL;
int err = 0;
Expand Down
7 changes: 7 additions & 0 deletions source/proxy_connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1565,6 +1565,13 @@ int aws_http_options_validate_proxy_configuration(const struct aws_http_client_c
return aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
}

#if defined(AWS_USE_SECITEM) && defined(AWS_OS_APPLE)
if ((options->proxy_options || options->proxy_ev_settings)) {
AWS_LOGF_ERROR(AWS_LS_HTTP_PROXY_NEGOTIATION, "HTTP proxy is not supported on Apple Network Framework.");
return aws_raise_error(AWS_ERROR_PLATFORM_NOT_SUPPORTED);
}
#endif

enum aws_http_proxy_connection_type proxy_type = options->proxy_options->connection_type;
if (proxy_type == AWS_HPCT_HTTP_FORWARD && options->tls_options != NULL) {
return aws_raise_error(AWS_ERROR_INVALID_STATE);
Expand Down