Fix rounding error in hpack resizing#559
Open
DmitriyMusatkin wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 79.76% 79.79% +0.03%
==========================================
Files 28 28
Lines 12085 12085
==========================================
+ Hits 9639 9643 +4
+ Misses 2446 2442 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TingDaoK
approved these changes
May 18, 2026
| context->dynamic_table.buffer_capacity | ||
| ? (size_t)(context->dynamic_table.buffer_capacity * s_hpack_dynamic_table_buffer_growth_rate) | ||
| /* increase buffer by 1.5 rounded up. */ | ||
| ? (size_t)(context->dynamic_table.buffer_capacity + ((context->dynamic_table.buffer_capacity + 1) / 2)) |
Contributor
There was a problem hiding this comment.
we cannot get a 0 buffer_capacity?
Will it be more clear if we do a min(context->dynamic_table.buffer_capacity / 2, 1)?
Contributor
Author
There was a problem hiding this comment.
from my reading of code, s_dynamic_table_resize_buffer supports new size of 0, which will result in buffer_capacity being 0.
wouldn't that min always result in 1?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.