Skip to content

Request response client: acquire event loop group#392

Merged
xiazhvera merged 17 commits into
mainfrom
get_eventloop_group
May 15, 2025
Merged

Request response client: acquire event loop group#392
xiazhvera merged 17 commits into
mainfrom
get_eventloop_group

Conversation

@xiazhvera
Copy link
Copy Markdown
Contributor

@xiazhvera xiazhvera commented May 5, 2025

Issue #, if available:

Description of changes:
Acquire event loop for rr_client.

In the previous implementation, releasing of the protocol client would potentially release the event loop group if no other component acquire the event loop group. This would cause a race condition where the rr_client or streaming operation is trying to use the event loop to process its tasks while the event loop has already be released. We fixed it by acquire the event loop group for rr client.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 5, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base (235f560) to head (7e230c2).

Files with missing lines Patch % Lines
source/request-response/request_response_client.c 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   84.66%   84.63%   -0.03%     
==========================================
  Files          25       25              
  Lines       10483    10489       +6     
==========================================
+ Hits         8875     8877       +2     
- Misses       1608     1612       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiazhvera xiazhvera marked this pull request as ready for review May 6, 2025 16:14
@xiazhvera xiazhvera changed the base branch from main to fail-operations-on-shutdown May 13, 2025 16:13
Base automatically changed from fail-operations-on-shutdown to main May 13, 2025 21:36
@xiazhvera xiazhvera merged commit 34646b2 into main May 15, 2025
36 checks passed
@xiazhvera xiazhvera deleted the get_eventloop_group branch May 15, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants