Request response client: acquire event loop group#392
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
==========================================
- Coverage 84.66% 84.63% -0.03%
==========================================
Files 25 25
Lines 10483 10489 +6
==========================================
+ Hits 8875 8877 +2
- Misses 1608 1612 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sfod
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Acquire event loop for rr_client.
In the previous implementation, releasing of the protocol client would potentially release the event loop group if no other component acquire the event loop group. This would cause a race condition where the rr_client or streaming operation is trying to use the event loop to process its tasks while the event loop has already be released. We fixed it by acquire the event loop group for rr client.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.