Skip to content

Log ack_timeout_seconds#402

Merged
sbSteveK merged 2 commits into
mainfrom
missing_log
Jun 18, 2025
Merged

Log ack_timeout_seconds#402
sbSteveK merged 2 commits into
mainfrom
missing_log

Conversation

@sbSteveK
Copy link
Copy Markdown
Contributor

ack_timeout_seconds was skipped during the logging of MQTT5's client options storage. It has been added.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.72%. Comparing base (f8c8598) to head (e5cff5a).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   84.71%   84.72%           
=======================================
  Files          25       25           
  Lines       10490    10492    +2     
=======================================
+ Hits         8887     8889    +2     
  Misses       1603     1603           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@sfod sfod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix and ship

Comment thread source/v5/mqtt5_options_storage.c Outdated
@sbSteveK sbSteveK merged commit 0024652 into main Jun 18, 2025
39 checks passed
@sbSteveK sbSteveK deleted the missing_log branch June 18, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants