Skip to content

Fix warnings found by the Undefined Behavior Sanitizer #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bjosv wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix warnings found by the Undefined Behavior Sanitizer #407

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
460ae4d
Fix warnings found by the Undefined Behavior Sanitizer
bjosv Aug 6, 2025
8356129
Merge branch 'main' into ubsan-fixes
bjosv Jan 21, 2026
ed3c545
Merge branch 'main' into ubsan-fixes
bjosv Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions source/client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ static void s_aws_mqtt_schedule_reconnect_task(struct aws_mqtt_client_connection
(void *)connection->loop);
}

static void s_aws_mqtt_client_destroy(struct aws_mqtt_client *client) {

static void s_aws_mqtt_client_destroy(void *user_data) {
struct aws_mqtt_client *client = user_data;
AWS_LOGF_DEBUG(AWS_LS_MQTT_CLIENT, "client=%p: Cleaning up MQTT client", (void *)client);
aws_client_bootstrap_release(client->bootstrap);

Expand Down Expand Up @@ -910,7 +910,8 @@ static void s_on_final_disconnect(struct aws_mqtt_client_connection *connection,
s_mqtt_client_connection_destroy_final(connection);
}

static void s_mqtt_client_connection_start_destroy(struct aws_mqtt_client_connection_311_impl *connection) {
static void s_mqtt_client_connection_start_destroy(void *user_data) {
struct aws_mqtt_client_connection_311_impl *connection = user_data;
bool call_destroy_final = false;

AWS_LOGF_DEBUG(
Expand Down