Skip to content

Manual Puback Logging Change #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbSteveK merged 2 commits into from
Mar 17, 2026
Merged

Manual Puback Logging Change #420

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e30c2fa
remove error log for acquire puback for qos0 publishes
sbSteveK Mar 17, 2026
94361ed
remove warning about duplicate control
sbSteveK Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions source/v5/mqtt5_client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2639,8 +2639,6 @@ uint64_t aws_mqtt5_client_acquire_puback(
AWS_FATAL_ASSERT(aws_event_loop_thread_is_callers_thread(client->loop));

if (publish_view->qos == AWS_MQTT5_QOS_AT_MOST_ONCE) {
AWS_LOGF_ERROR(
AWS_LS_MQTT5_CLIENT, "id=%p: PUBACK control cannot be taken for a QoS 0 PUBLISH packet.", (void *)client);
return 0;
}

Expand All @@ -2653,10 +2651,6 @@ uint64_t aws_mqtt5_client_acquire_puback(
/* In this case we simply provide the same control_id that was already sent before. We do not want to create a
* second control_id with the same packet_id. It is the user's responsibility to know that they have two PUBACKs
* for the same PUBLISH. */
AWS_LOGF_WARN(
AWS_LS_MQTT5_CLIENT,
"id=%p: PUBACK acquire called on a PUBLISH that is already under user control.",
(void *)client);
struct aws_mqtt5_manual_puback_entry *entry = elem->value;
return entry->puback_control_id;
}
Expand Down
Loading