update first byte timeout algo#461
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
==========================================
+ Coverage 89.66% 89.70% +0.04%
==========================================
Files 20 20
Lines 6354 6381 +27
==========================================
+ Hits 5697 5724 +27
Misses 657 657
🚀 New features to boost your workflow:
|
waahm7
reviewed
Apr 23, 2025
waahm7
approved these changes
Apr 29, 2025
jet-tong
added a commit
to jet-tong/s3-connector-for-pytorch
that referenced
this pull request
May 13, 2025
Update to mountpoint-s3-client v0.14.1 to address CRT timeout issues and adapt to API changes: - Include aws-c-s3 first byte timeout fix (awslabs/aws-c-s3/pull/461) - Update get_object functions to use new GetBodyPart type (awslabs/mountpoint-s3/pull/1348) This addresses AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT CRT error.
1 task
jet-tong
added a commit
to jet-tong/s3-connector-for-pytorch
that referenced
this pull request
May 13, 2025
Update to mountpoint-s3-client v0.14.1 to address CRT timeout issues and adapt to API changes: - Include aws-c-s3 first byte timeout fix (awslabs/aws-c-s3/pull/461) - Update get_object functions to use new GetBodyPart type (awslabs/mountpoint-s3/pull/1348) This addresses AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT CRT error.
jet-tong
added a commit
to jet-tong/s3-connector-for-pytorch
that referenced
this pull request
May 13, 2025
Update to mountpoint-s3-client v0.14.1 to address CRT timeout issues and adapt to API changes: - Include aws-c-s3 first byte timeout fix (awslabs/aws-c-s3/pull/461) - Update get_object functions to use new GetBodyPart type (awslabs/mountpoint-s3/pull/1348) This addresses AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT CRT error.
jet-tong
added a commit
to jet-tong/s3-connector-for-pytorch
that referenced
this pull request
May 13, 2025
Update to mountpoint-s3-client v0.14.1 to address CRT timeout issues and adapt to API changes: - Include aws-c-s3 first byte timeout fix (awslabs/aws-c-s3/pull/461) - Update get_object functions to use new GetBodyPart type (awslabs/mountpoint-s3/pull/1348) This addresses AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT CRT error.
jet-tong
added a commit
to jet-tong/s3-connector-for-pytorch
that referenced
this pull request
May 13, 2025
Update to mountpoint-s3-client v0.14.1 to address CRT timeout issues and adapt to API changes: - Include aws-c-s3 first byte timeout fix (awslabs/aws-c-s3/pull/461) - Update get_object functions to use new GetBodyPart type (awslabs/mountpoint-s3/pull/1348) This addresses AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT CRT error.
IsaevIlya
pushed a commit
to jet-tong/s3-connector-for-pytorch
that referenced
this pull request
May 13, 2025
Update to mountpoint-s3-client v0.14.1 to address CRT timeout issues and adapt to API changes: - Include aws-c-s3 first byte timeout fix (awslabs/aws-c-s3/pull/461) - Update get_object functions to use new GetBodyPart type (awslabs/mountpoint-s3/pull/1348) This addresses AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT CRT error.
IsaevIlya
pushed a commit
to awslabs/s3-connector-for-pytorch
that referenced
this pull request
May 13, 2025
Update to mountpoint-s3-client v0.14.1 to address CRT timeout issues and adapt to API changes: - Include aws-c-s3 first byte timeout fix (awslabs/aws-c-s3/pull/461) - Update get_object functions to use new GetBodyPart type (awslabs/mountpoint-s3/pull/1348) This addresses AWS_ERROR_HTTP_RESPONSE_FIRST_BYTE_TIMEOUT CRT error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Current main benchmark 1x30GiB file upload with c5n.18xlarge:
With this change same workload:
Overall there is no performance downgrade from this change on the benchmark.
Meanwhile, if I just disable the timeout, the same workload result in:
there is an around 22% performance downgrade.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.