Skip to content

don't regenerate the checksum#531

Closed
TingDaoK wants to merge 3 commits intomainfrom
no-regenerate-checksum
Closed

don't regenerate the checksum#531
TingDaoK wants to merge 3 commits intomainfrom
no-regenerate-checksum

Conversation

@TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Jun 26, 2025

Issue #, if available:

  • We previously clean up the checksum after prepare.
  • It results in the checksum to be recalculated during retry
  • It's violating the durability guarantee
  • However, since we already buffer the input in memory during retry, it won't read the customer input again, which mitigated the impact.

Description of changes:

  • Revamp the code a bit to allow the passed in checksum to the input stream wrappers. So that it won't recalculate the checksum

TODO:

  • The whole checksum logic is already complicated this makes it more weird, need to revamp it...
  • I'd prefer to push the revamp of the checksum logic later when we implement the full object checksum.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.36364% with 13 lines in your changes missing coverage. Please review.

Project coverage is 89.52%. Comparing base (1762f83) to head (1ae6022).

Files with missing lines Patch % Lines
source/s3_chunk_stream.c 73.52% 9 Missing ⚠️
source/s3_request_messages.c 76.47% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   89.57%   89.52%   -0.05%     
==========================================
  Files          21       21              
  Lines        6541     6561      +20     
==========================================
+ Hits         5859     5874      +15     
- Misses        682      687       +5     
Files with missing lines Coverage Δ
source/s3_auto_ranged_put.c 92.39% <100.00%> (+0.03%) ⬆️
source/s3_request_messages.c 74.00% <76.47%> (-0.37%) ⬇️
source/s3_chunk_stream.c 77.35% <73.52%> (+0.48%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TingDaoK TingDaoK marked this pull request as ready for review July 1, 2025 18:04
@TingDaoK TingDaoK closed this Jul 2, 2025
@TingDaoK
Copy link
Contributor Author

TingDaoK commented Jul 2, 2025

Included in #532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments