Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 23 23
Lines 7585 7585
=======================================
Hits 6761 6761
Misses 824 824 🚀 New features to boost your workflow:
|
azkrishpy
reviewed
Nov 28, 2025
| else: | ||
| partition = download_from_git('https://raw.githubusercontent.com/aws/aws-sdk-cpp/main/tools/code-generation/partitions/partitions.json') | ||
| partition = download_from_git( | ||
| 'https://raw.githubusercontent.com/aws/aws-sdk-cpp/main/tools/code-generation/partitions/partitions.json') |
Contributor
There was a problem hiding this comment.
Are we still using CPP sdk for something specific? I thought we were moving to public models instead of relying on CPP sdk?
Contributor
Author
There was a problem hiding this comment.
only rule set are available from the model, the partition is not.
The baseline partitions.json file will be delivered via a SDK release tool that we are not on. So, we still need to grab it via C++ SDK.
azkrishpy
approved these changes
Dec 3, 2025
DmitriyMusatkin
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.