Skip to content

Conversation

@TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Nov 26, 2025

Issue #, if available:

  • If we can handle this nicely instead of crash, it will help people to debug this and help us to debug it as well.
  • Unexpected behavior that the server response is not what we ask for is not really worth to crash for. We still have chance to handle this error.
  • We SHOULD only crash if something worse will happen afterward, otherwise, handle the error!

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.13%. Comparing base (f25cb50) to head (5a1e81a).

Files with missing lines Patch % Lines
source/s3_meta_request.c 37.50% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
- Coverage   89.19%   89.13%   -0.06%     
==========================================
  Files          23       23              
  Lines        7577     7585       +8     
==========================================
+ Hits         6758     6761       +3     
- Misses        819      824       +5     
Files with missing lines Coverage Δ
source/s3_meta_request.c 91.00% <37.50%> (-0.36%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TingDaoK TingDaoK merged commit 3f81fc9 into main Nov 26, 2025
38 checks passed
@TingDaoK TingDaoK deleted the better-error-handling branch November 26, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants