Skip to content

[fix]S3express backpressure#612

Merged
TingDaoK merged 5 commits intomainfrom
s3express-backpressure
Jan 13, 2026
Merged

[fix]S3express backpressure#612
TingDaoK merged 5 commits intomainfrom
s3express-backpressure

Conversation

@TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Jan 13, 2026

Issue #, if available:

  • The backpressure was not working correctly with s3express in case where if the window size is smaller than the response, it will stuck.
  • We are limiting all response with a body callback for backpressure which should not be.

Description of changes:

  • only limit the request that is a get object with back pressure.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK changed the title S3express backpressure [fix]S3express backpressure Jan 13, 2026
if (meta_request->body_callback && meta_request->client->enable_read_backpressure) {
/* If customer set the body callback, make sure we are not delivery them more than asked via the
* callback. */
if (s_apply_backpressure(request)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (s_apply_backpressure(request)) {
if (s_should_apply_backpressure(request)) {

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.14%. Comparing base (3a2d31a) to head (d8ad711).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #612   +/-   ##
=======================================
  Coverage   89.13%   89.14%           
=======================================
  Files          23       23           
  Lines        7585     7591    +6     
=======================================
+ Hits         6761     6767    +6     
  Misses        824      824           
Files with missing lines Coverage Δ
source/s3_meta_request.c 91.05% <100.00%> (+0.04%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TingDaoK TingDaoK merged commit e9d1bde into main Jan 13, 2026
38 of 39 checks passed
@TingDaoK TingDaoK deleted the s3express-backpressure branch January 13, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants