Skip to content

Commit 0da386b

Browse files
azkrishpyTingDaoK
andauthored
commit doc update suggestion
Co-authored-by: Dengke Tang <dengket@amazon.com>
1 parent 16dd720 commit 0da386b

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

builder/actions/cmake.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -198,11 +198,9 @@ def _build_project(env, project, cmake_extra, build_tests=False, args_transforme
198198
working_dir = env.root_dir if toolchain.cross_compile else os.getcwd()
199199

200200
# Previous use of UniqueList did not allow multiple appends to the list of the same key value pair.
201-
# Adding a new method 'unique_flags' which allows all args to be appended, but in the final set, we remove
202-
# multiple declarations of certain flags keeping the last occurrence.
203-
# CMake inherently supports multiple arguments and traverses from left to right and constantly updates the
204-
# flag value based on latest read. However, windows does not support some flags being duplicated ('-A'
205-
# or '-T') which would cause windows CI to fail.
201+
# CMake inherently supports multiple arguments and traverses from left to right and constantly updates the flag value based on latest read.
202+
# However, windows does not support some flags being duplicated ('-A' or '-T') which would cause windows failed to build.
203+
# Thus, adding a new method 'unique_flags' to remove multiple declarations of those flags keeping the last occurrence.
206204
cmake_args = unique_flags(cmake_args, '-A', '-T')
207205

208206
# configure

0 commit comments

Comments
 (0)