-
Notifications
You must be signed in to change notification settings - Fork 7
latest-clang #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sbSteveK
wants to merge
8
commits into
main
Choose a base branch
from
latest-clang
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
latest-clang #343
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9b2ebe9
handle latest-clang to get latest qualification version to build with
sbSteveK 400b450
remove hardcoded versioning for clang post 8 to support later version…
sbSteveK 6c6d286
check whether latest versions we want are actually downloadable befor…
sbSteveK 09fda2b
add additional logging to describe what's happening. Cache per codena…
sbSteveK 9fb9db5
insig change to kick off ci
sbSteveK 4b4e7ad
deeper check for older versions
sbSteveK f904d92
pr changes
sbSteveK f2f0ba4
pr changes
sbSteveK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, we are trying to resolve the latest one available when the version is not set, but we are also introducing a new
latestversion?Sounds like we should just resolve the latest version dynamically when the version is
Noneinstead of the latest one in the hard-coded list?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We introduce
latestto be explicit about what we want to do when calling from CI; find the latest version of clang that can be used from llvm.Nonesimply asks to use any available version and doesn't go through the process of looking for latest from llvm. I think we should keep this separation in behavior.