Enable Windows-on-ARM64 builds by fixing arch detection and adding Windows ARM CI#349
Open
tsomanna wants to merge 2 commits into
Open
Enable Windows-on-ARM64 builds by fixing arch detection and adding Windows ARM CI#349tsomanna wants to merge 2 commits into
tsomanna wants to merge 2 commits into
Conversation
Author
|
Hi, any updates on this? |
Contributor
|
Hi @tsomanna, unfortunately, we don't currently have the bandwidth to review and tests the changes. Windows ARM64 support is on our roadmap, however, we don't have a timeline to share at this point. |
Author
|
Hi @xiazhvera, we'd be happy to help you out with testing. Let us know if that works for you and what tests you'd like us to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Several AWS CRT projects rely on
builder.pyzfor builds (e.g.,aws-c-event-stream). Today, whenbuilder.pyzruns on a Windows ARM64 machine, architecture detection reportsx64, which blocks native ARM64 workflows and prevents downstream projects from producing native ARM64 artifacts.Adding Windows ARM64 support here improves developer experience and reduces dependency on x64 emulation for Windows-on-ARM platforms.
Description of changes:
builder/core/host.py)platform.machine()on Windows to detect ARM64armv8builder/core/data.py)armv8to MSVC architectures with CMake args-AARM64windows-armv8to the platform setwindows-armv8:windows-arm64,windows-arm64v8,windows-arm64v8a,windows-aarch64.github/workflows/sanity-test.yml)windows-11-arm) to the sanity test matrix to ensure this code path is exercised in CI.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.