Open
Conversation
…into iot_metrics
This reverts commit 4bf6518.
sfod
reviewed
Feb 2, 2026
Comment on lines
+673
to
676
| /** Enable AWS IoT Metrics Collection. This is always set to true for now. */ | ||
| bool m_enableMetricsCollection; | ||
|
|
||
| Crt::String m_sdkName = "CPPv2"; | ||
| Crt::String m_sdkVersion = AWS_CRT_CPP_VERSION; |
Contributor
There was a problem hiding this comment.
Shouldn't we remove this? I think struct IoTDeviceSDKMetrics handles the metrics now.
Contributor
Author
There was a problem hiding this comment.
Long story short: Let's keep it as-is for now.
And for more context: Unfortunately, IoT SDK CPP exposes APIs to set sdkName/sdkVersion, so users could technically be relying on the APIs to update the SDK name.And let's not breaking them for now.
CRT currently doesn't expose any API to modify metrics. The only way to do so today is by manually setting the username field. Let's preserve that behavior for now to prevent users from modifying metrics directly. We'll expose a proper metrics API once the metadata work is complete with struct IoTDeviceSDKMetrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
IoTDeviceSDKMetricsand metrics related features , CRT is now appending AWS metrics by default.enableMetricsoption to allow user disable metrics.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.