Skip to content

CRT Reference Logging Update #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbSteveK merged 6 commits into from
Oct 24, 2025
Merged

CRT Reference Logging Update #926

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
beb8cee
add additional info when calling decref
sbSteveK Oct 24, 2025
7ed3e3e
overload the decRef() instead of chainging the existing one
sbSteveK Oct 24, 2025
256f146
docs
sbSteveK Oct 24, 2025
b949e52
doc params
sbSteveK Oct 24, 2025
b9ba9d2
use the CrtResource instead of String and long)
sbSteveK Oct 24, 2025
25d430c
change uses
sbSteveK Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions src/main/java/software/amazon/awssdk/crt/CrtResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public void removeReferenceTo(CrtResource resource) {
return;
}

resource.decRef();
resource.decRef(this.getClass().getCanonicalName(), id);
}

/**
Expand Down Expand Up @@ -280,12 +280,21 @@ public void close() {
/**
* Decrements the reference count to this resource. If zero is reached, begins (and possibly completes) the resource's
* cleanup process.
* @param decRefInstigator Canonical Name of instigating CrtResource
* @param decRefInstigatorId id of instigating CrtResource
*/
public void decRef() {
public void decRef(String decRefInstigator, long decRefInstigatorId) {
Comment thread
sbSteveK marked this conversation as resolved.
Outdated
int remainingRefs = refCount.decrementAndGet();

if (debugNativeObjects) {
Log.log(ResourceLogLevel, Log.LogSubject.JavaCrtResource, String.format("Closing instance of class %s(%d) with %d remaining refs", this.getClass().getCanonicalName(), id, remainingRefs));
if (decRefInstigator != null) {
Log.log(ResourceLogLevel, Log.LogSubject.JavaCrtResource, String.format(
"DecRef instance of class %s(%d) called by %s(%d). %d remaining refs", this.getClass().getCanonicalName(),
id, decRefInstigator, decRefInstigatorId, remainingRefs));
} else {
Log.log(ResourceLogLevel, Log.LogSubject.JavaCrtResource, String.format("DecRef instance of class %s(%d) via self.close(). %d remaining refs",
this.getClass().getCanonicalName(), id, remainingRefs));
}
}

if (remainingRefs != 0) {
Expand All @@ -298,6 +307,12 @@ public void decRef() {
releaseReferences();
}
}
/**
* Decrements the reference count to this resource.
*/
public void decRef() {
decRef(null, -1);
}

/**
* Decrements the ref counts for all resources referenced by this resource. Most resources will have this called
Expand All @@ -311,7 +326,7 @@ protected void releaseReferences() {

synchronized(this) {
for (CrtResource resource : referencedResources) {
resource.decRef();
resource.decRef(this.getClass().getCanonicalName(), id);
}

referencedResources.clear();
Expand Down
Loading