Dispatch Queue for macOS#929
Merged
Merged
Conversation
sfod
reviewed
Nov 5, 2025
sfod
reviewed
Nov 12, 2025
sfod
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dealing with Dispatch Queue threads we need to attach and detatch them to and from the JVM during the operational period of the thread. For non Dispatch Queue threads we add a callback that invokes and handles the detatch from JVM when the aws_thread exits. For Dispatch Queue we have no control over which threads are used, in what order, or their lifetimes so we detach as soon as we are done using them in callbacks.
Added additional logging to
CrtResource.decRefto help with tracking of what is decreffing what.The CI Jobs we have listed as non-required due to their extensive length runs and android device farm have been split into their own separate workflows.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.