Expose async writes to HTTP Stream Manager#987
Merged
Merged
Conversation
TingDaoK
reviewed
May 12, 2026
|
|
||
| data_cur = aws_byte_cursor_from_buf(&callback_data->data_buf); | ||
| callback_data->data_stream = aws_input_stream_new_from_cursor(aws_jni_get_allocator(), &data_cur); | ||
| /* |
Contributor
There was a problem hiding this comment.
let's add a test for this, if we don't already have one.
invoke the write data API with a local variable (Or somehow remove the reference to the object from java side). We should sill keep the data alive and works as expected since we keep the object referenced in C here.
Contributor
Author
There was a problem hiding this comment.
modified the existing happy path tests to create weak references and remove object, forced a gc and checked for the the weak reference to not be null.
TingDaoK
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.