Skip to content

Update crt modules #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DmitriyMusatkin wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update crt modules #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da1790d
pick up s3 changes
DmitriyMusatkin May 15, 2026
8b512a8
common as well
DmitriyMusatkin May 15, 2026
a1daa23
more
DmitriyMusatkin May 15, 2026
0df8b4d
fix test
DmitriyMusatkin May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crt/aws-c-auth
Open in desktop
Submodule aws-c-auth updated 5 files
+2 −1 .github/workflows/ci.yml
+4 −2 source/aws_imds_client.c
+1 −1 source/credentials_provider_ecs.c
+1 −0 tests/CMakeLists.txt
+62 −0 tests/credentials_provider_ecs_tests.c
2 changes: 1 addition & 1 deletion crt/aws-c-common
Open in desktop
Submodule aws-c-common updated 18 files
+55 −26 .github/workflows/ci.yml
+1 −1 .github/workflows/clang-format.yml
+1 −1 .github/workflows/clang-tidy.yml
+2 −2 .github/workflows/codecov.yml
+9 −0 builder.json
+72 −0 include/aws/common/byte_buf.h
+10 −0 include/aws/common/byte_order.h
+30 −0 include/aws/common/byte_order.inl
+4 −1 include/aws/common/ring_buffer.inl
+20 −0 include/aws/common/xml_parser.h
+94 −4 source/byte_buf.c
+125 −0 source/xml_parser.c
+7 −0 tests/CMakeLists.txt
+2 −2 tests/alloc_test.c
+57 −0 tests/byte_buf_test.c
+103 −0 tests/cursor_test.c
+47 −0 tests/split_test.c
+124 −0 tests/xml_parser_test.c
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<cmake.osx_arch>-DOSX_ARCH_DUMMY=1</cmake.osx_arch>
<cmake.min_osx_version>-DOSX_DEPLOYMENT_TARGET_DUMMY=1</cmake.min_osx_version>
<cmake.crt_fips>OFF</cmake.crt_fips>
<maven-surefire-plugin.version>2.21.0</maven-surefire-plugin.version>
<maven-surefire-plugin.version>3.2.5</maven-surefire-plugin.version>
</properties>

<profiles>
Expand Down Expand Up @@ -498,7 +498,7 @@
<shutdown>kill</shutdown>
<argLine>-Daws.crt.memory.tracing=2 -Xcheck:jni</argLine>
<runOrder>alphabetical</runOrder>
<useFile>false</useFile>
<useFile>true</useFile>
<reuseForks>false</reuseForks>
<forkCount>0</forkCount>
<testFailureIgnore>false</testFailureIgnore>
Expand Down
9 changes: 6 additions & 3 deletions src/test/java/software/amazon/awssdk/crt/test/CredentialsProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
import java.util.List;
import java.util.concurrent.*;

import software.amazon.awssdk.crt.Log;

import static org.junit.Assert.*;
import static org.junit.Assert.fail;

Expand Down Expand Up @@ -289,6 +291,7 @@ public void testCreateDestroyProfile_InvalidProfile() throws IOException {

@Test
public void testCreateDestroyProfile_MissingCreds() throws ExecutionException, InterruptedException, IOException {
Log.initLoggingToStderr(Log.LogLevel.Trace);
Path confPath = Files.createTempFile("testCreateDestroyProfile_ValidProfile_conf_", "");
Path credsPath = Files.createTempFile("testCreateDestroyProfile_ValidProfile_creds_", "");
Files.write(credsPath, Arrays.asList("[default]")); // Contains a section header but no actual credentials
Expand All @@ -297,18 +300,18 @@ public void testCreateDestroyProfile_MissingCreds() throws ExecutionException, I
.withConfigFileNameOverride(confPath.toString()).withCredentialsFileNameOverride(credsPath.toString());

try (ProfileCredentialsProvider provider = builder.build()) {
assertNotNull(provider);
assertNotNull("provider is null", provider);
assertTrue(provider.getNativeHandle() != 0);

try {
provider.getCredentials().join();
fail("Expected credential fetching to throw an exception since creds are missing from profile");
} catch (CompletionException e) {
assertNotNull(e.getCause());
assertNotNull("exception is null", e.getCause());
Throwable innerException = e.getCause();

// Check that the right exception type caused the completion error in the future
assertTrue(innerException.getMessage().contains("Parser encountered an error"));
assertEquals(innerException.getMessage(), "Valid credentials could not be sourced by a profile provider");
assertEquals(CrtRuntimeException.class, innerException.getClass());
}
} finally {
Expand Down
Loading