Add IoT Metrics Support#680
Merged
Merged
Conversation
… into iot_metrics
bretambrose
reviewed
Mar 25, 2026
| }) | ||
| }); | ||
|
|
||
| test_env.conditional_test(test_env.AWS_IOT_ENV.mqtt311_is_valid_direct_auth_mqtt())('MQTT311 Connection - basic auth with metrics', async () => { |
Contributor
There was a problem hiding this comment.
Can we do this against IoT Core; as it stands this will only get run in codebuild
Contributor
Author
There was a problem hiding this comment.
The test cannot run against IoT Core, as IoT Core will rule out the metrics string. The test actually uses the connection failure to verify that the metrics are appended.
Contributor
Author
|
TODO: as we have a mock server in place with the nodejs change, we will modify the test to use the mock server so we can actually capture the package and verify that the metrics are appended propelry. |
bretambrose
reviewed
Apr 8, 2026
bretambrose
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Bind
IoTDeviceSDKMetricsand metrics related features , CRT is now appending AWS metrics by default.Creating a shared base interface for MqttConnectionConfig and Mqtt5ClientOption
Node: Add
disableMetricsoption to allow user disable metrics.disable_metricsoption in MqttConnectionConfigdisableMetricsoption in Mqtt5ClientOptionBrowser:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.