JS Mqtt - PR #2 Data model and packet logging#695
Open
bretambrose wants to merge 15 commits into
Open
Conversation
added 5 commits
March 6, 2026 12:25
xiazhvera
reviewed
Mar 25, 2026
added 4 commits
March 30, 2026 09:13
sbSteveK
reviewed
Apr 8, 2026
| export const CONNECT_FLAGS_HAS_WILL : number = 0x04; | ||
| export const CONNECT_FLAGS_QOS_SHIFT : number = 0x03; | ||
| export const CONNECT_FLAGS_WILL_RETAIN : number = 0x20; | ||
| export const CONNECT_FLAGS_CLEAN_SESSION : number = 0x02; |
Contributor
There was a problem hiding this comment.
Just griping to the void (you) that MQTT5 spec names this flag Clean Start and MQTT3.1.1 names it Clean Session
sbSteveK
reviewed
Apr 8, 2026
sbSteveK
approved these changes
Apr 8, 2026
added 5 commits
April 9, 2026 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional packet definitions and helper functions for the internal JS MQTT client. Beyond what we currently expose in mqtt5_packet, we add two additional models:
Also includes logging related functionality:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.