Add Dotnet Benchmark Runner#103
Draft
GarrettBeatty wants to merge 44 commits into
Draft
Conversation
GarrettBeatty
commented
May 8, 2025
graebm
reviewed
May 8, 2025
Comment on lines
+74
to
+77
| foreach (var task in workloadConfig.Tasks) | ||
| { | ||
| var startTime = DateTimeOffset.UtcNow; | ||
| for (int run = 1; run <= workloadConfig.MaxRepeatCount; run++) |
Contributor
There was a problem hiding this comment.
The runner isn't supposed to time how long each individual task takes. It's supposed to time how long it takes to do ALL tasks in the workload.
This is because many Transfer Managers have "upload folder" functionality, where they do a lot of work in parallel, and it often takes a lot of parallel work to really max out the machine.
If you don't want to support parallel work in this first draft, then if you get a workload with multiple tasks, have the runner quit with the special "skipping workload" exit code: 123.
Author
There was a problem hiding this comment.
updated to use upload folder functionality and updated the time to be all of the tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add Dotnet benchmark runner. I ran locally for both download and upload and it successfully prints out the results.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.