[DRAFT] Add a null check for the lower level (de)serializer in ReleaseUnmanagedResources method during dispose flow of C# SerDe objects to avoid NPEs during disposal #458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a null check for the lower level (de)serializer in
ReleaseUnmanagedResourcesmethod during dispose flow of C# SerDe objectsIssue #, if available:
Right now, the
Disposemethods inGlueSchemaRegistryDeserializerandGlueSchemaRegistrySerializerwhich are called duringFinalizeflow (triggered during garbage collection) are not thread safe.However, it needs to be thread-safe as per recommendation. Ref: https://stackoverflow.com/questions/5306860/should-idisposable-dispose-be-made-safe-to-call-multiple-times
Description of changes:
We are handling a specific exception during the dispose flow (
NullReferenceException) by checking if the lower-level serializer or deserializer object is null.Before the null-check
After the null-check
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.