Skip to content

Support Cognito multiple issuer properties#238

Open
edwsun wants to merge 2 commits intoawslabs:mainfrom
edwsun:main
Open

Support Cognito multiple issuer properties#238
edwsun wants to merge 2 commits intoawslabs:mainfrom
edwsun:main

Conversation

@edwsun
Copy link
Copy Markdown

@edwsun edwsun commented Jan 17, 2026

Issue #, if available: #237

Description of changes: Added support for Cognito multi-region issuer property, consolidated and optimized regex pattern. Minor typo fix.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@amazon-inspector-ireland
Copy link
Copy Markdown

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-ireland
Copy link
Copy Markdown

✅ I finished the code review, and didn't find any security or code quality issues.

@hakanson
Copy link
Copy Markdown
Contributor

this changed the signature on public static parseUserPoolId which would require a major version release. I have an alternate PR #239 that uses optional parameters that is backwards compatible and can be minor version release, therefore more likely to be included into existing projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants