-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: S3 Express support #1906
Draft
jbelkins
wants to merge
9
commits into
main
Choose a base branch
from
jbe/s3_express
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: S3 Express support #1906
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
76b7286
Add S3 codegen
jbelkins fec058f
Runtime & codegen changes
jbelkins 9bf1e9f
Fix codegen tests
jbelkins 6171042
Fix ktlint
jbelkins 91d5131
fix Swiftlint
jbelkins 1c23aeb
Merge branch 'main' into jbe/s3_express
jbelkins 75d558a
Merge branch 'main' into jbe/s3_express
jbelkins f1c87c1
Add env var & profile config for disableS3ExpressSessionAuth
jbelkins a451df5
Merge branch 'main' into jbe/s3_express
jbelkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just fixes a concurrency issue; the nonconcurrent code called here should be called using
withCheckedThrowingContinuation
.