feat: Add Swift 6 language mode support #1916
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayaffe
commented
Apr 17, 2025
There was a problem hiding this comment.
Ignore these changes
dayaffe
commented
Apr 17, 2025
dayaffe
commented
Apr 17, 2025
There was a problem hiding this comment.
Ignore this it will be removed
sichanyoo
reviewed
Apr 18, 2025
| @@ -15,7 +15,7 @@ import struct Smithy.Attributes | |||
| import struct Smithy.AttributeKey | |||
|
|
|||
| /// Signs a `Message` using the AWS SigV4 signing algorithm | |||
| public class AWSMessageSigner: MessageSigner { | |||
| public class AWSMessageSigner: MessageSigner, @unchecked Sendable { | |||
There was a problem hiding this comment.
General question: unchecked tag on the following:
- AWSMessageSigner
- AWSSigV4Signer
What's the background on these having unchecked?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.