Open
Conversation
jbelkins
commented
Mar 29, 2026
| class AWSJSONCustomizations : AWSHTTPProtocolCustomizations() { | ||
| class AWSJSONCustomizations( | ||
| private val version: String, | ||
| ) : AWSHTTPProtocolCustomizations() { |
Collaborator
Author
There was a problem hiding this comment.
This type now has a version param so it can be tailored for either AWS JSON 1.0 or 1.1.
jbelkins
commented
Mar 29, 2026
| _ = try await mockClient.getQueueUrl(input: .init(queueName: "non-existent-queue")) | ||
| XCTFail("Expected QueueDoesNotExist error") | ||
| } catch let error as AWSServiceError { | ||
| } catch let error as QueueDoesNotExist { |
Collaborator
Author
There was a problem hiding this comment.
We were not checking for this modeled error type before (we would have failed if we did, because an unknown error was being thrown.)
jbelkins
commented
Mar 29, 2026
| // TODO: Establish why errorCode should be different depending on how the | ||
| // error was matched (this exposes implementation) | ||
| // XCTAssertEqual(error.errorCode, "QueueDoesNotExist", | ||
| // "Error code should be parsed from __type field when header is missing") |
Collaborator
Author
There was a problem hiding this comment.
No longer checking this code value because we model error code as static for a modeled error type, and passing TC1 & TC2 requires passing different error codes for the same type
jbelkins
commented
Mar 29, 2026
| @@ -18,9 +18,6 @@ import class ClientRuntime.OrchestratorTelemetry | |||
| import class ClientRuntime.SdkHttpClient | |||
| import class Smithy.Context | |||
Collaborator
Author
There was a problem hiding this comment.
This & the next several files contain generated changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.