Skip to content

add local swiftlint analyzer script to mimic CI + add to gradlew #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dayaffe merged 5 commits into from
Apr 8, 2026
+64 −0
Merged

add local swiftlint analyzer script to mimic CI + add to gradlew #2135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7730982
add local swiftlint analyzer script to mimic CI + add to gradlew
dayaffe Apr 6, 2026
5924d75
Merge branch 'main' into day/swiftlint-analyzer
dayaffe Apr 6, 2026
04f3286
Merge branch 'main' into day/swiftlint-analyzer
dayaffe Apr 7, 2026
5e4e90a
Merge branch 'main' into day/swiftlint-analyzer
dayaffe Apr 7, 2026
b4ecf2a
Merge branch 'main' into day/swiftlint-analyzer
dayaffe Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,23 @@ tasks.register<JavaExec>("ktlintFormat") {
main = "com.pinterest.ktlint.Main"
args = listOf("-F") + lintPaths
}

// Swift lint tasks (mirrors CI lint.yml workflow)

tasks.register<Exec>("swiftlint") {
description = "Run swiftlint (standard + analyzer on compiled code), matching CI."
group = "Verification"
commandLine("bash", "scripts/swiftlint-ci.sh")
}

tasks.register<Exec>("swiftlintFormat") {
description = "Auto fix Swift lint violations (standard + analyzer)."
group = "formatting"
commandLine("bash", "scripts/swiftlint-ci.sh", "--fix")
}

tasks.register<Exec>("swiftlintAnalyze") {
description = "Run swiftlint analyzer only (requires compilation)."
group = "Verification"
commandLine("bash", "scripts/swiftlint-ci.sh", "--analyze-only")
}
Copy link
Copy Markdown
Contributor

@jbelkins jbelkins Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've never had Gradle tasks for swiftlint before... is there a reason we're adding them versus just calling the script directly?

Copy link
Copy Markdown
Contributor Author

@dayaffe dayaffe Apr 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would make it easy/consistent to run since we already use a gradle task for ktlint (note this is just for local use and CI is not using it)

44 changes: 44 additions & 0 deletions scripts/swiftlint-ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
#!/bin/bash
#
# Runs swiftlint the same way CI does, including the analyzer pass on compiled code.
# Usage: ./scripts/swiftlint-ci.sh [--analyze-only | --lint-only] [--fix]
#
set -euo pipefail
cd "$(dirname "$0")/.."

MODE="all"
FIX=""
for arg in "$@"; do
case "$arg" in
--fix) FIX="--fix" ;;
--lint-only) MODE="lint" ;;
--analyze-only) MODE="analyze" ;;
-h|--help)
echo "Usage: $0 [--analyze-only | --lint-only] [--fix]"
exit 0
;;
*) echo "Unknown arg: $arg"; exit 1 ;;
esac
done

run_lint() {
swiftlint --strict $FIX
}

run_analyze() {
rm -rf Sources/Services/*
cd AWSSDKSwiftCLI
swift run AWSSDKSwiftCLI generate-package-manifest ..
cd ..
xcodebuild -scheme aws-sdk-swift-Package -destination platform=macOS > xcodebuild.log 2>&1 || {
echo "xcodebuild failed. See xcodebuild.log"
exit 1
}
swiftlint analyze --strict --compiler-log-path xcodebuild.log $FIX
}

case "$MODE" in
lint) run_lint ;;
analyze) run_analyze ;;
all) run_lint; run_analyze ;;
esac
Loading