chore: harden GitHub Actions workflows - #2170
Open
jonathan343 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR hardens several GitHub Actions workflows to resolve zizmor findings around action pinning, token scope, credential persistence, and shell template expansion.
I highly recommend the team considers the following:
github-actionsto keep actions up to date.awslabsorg has some limitations against third-party actions so avoid using zizmor-action for now.Summary
uses:references to full commit SHAs while retaining version comments for readability.persist-credentials: falseonactions/checkoutsteps that do not need persisted Git credentials.id-token: writedown from the workflow level to only the jobs that assume an AWS role inintegration-test.yml, instead of granting it to every job in the workflow.${{ inputs.* }}interpolation insiderun:blocks of thecheckout-smithy-swift-composite-actionwithenv:-passed variables to prevent shell template-injection.cooldownfor the existing gitsubmodule updater so new releases bake before being proposed.These changes address the relevant zizmor audit guidance for
unpinned-uses,excessive-permissions,artipacked, andtemplate-injection.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.