-
Notifications
You must be signed in to change notification settings - Fork 221
support auto mode advanced networking features #1210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Ready for functional validation |
shapirov103
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
still needs func test |
shapirov103
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a test under examples. I added support to run adhoc stacks (i did it for customer issues ) in #1218.
You can just add a file under examples with a more or less descriptive name and I will test it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing to " requested changes" for functional test
|
@shapirov103 functional test added and tested |
Issue #, if available:
#1175
Description of changes:
Creates a NodeClass and NodePool spec specifically for automode, and adds an extra nodeclass field to the automode cluster provider to support them
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.