Skip to content

Conversation

@zjaco13
Copy link
Contributor

@zjaco13 zjaco13 commented Nov 5, 2025

Issue #, if available:
#1175
Description of changes:
Creates a NodeClass and NodePool spec specifically for automode, and adds an extra nodeclass field to the automode cluster provider to support them

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shapirov103
Copy link
Collaborator

Ready for functional validation

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjaco13
Copy link
Contributor Author

zjaco13 commented Dec 18, 2025

still needs func test

Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test under examples. I added support to run adhoc stacks (i did it for customer issues ) in #1218.
You can just add a file under examples with a more or less descriptive name and I will test it out.

@shapirov103 shapirov103 self-requested a review December 18, 2025 19:00
Copy link
Collaborator

@shapirov103 shapirov103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing to " requested changes" for functional test

@zjaco13
Copy link
Contributor Author

zjaco13 commented Jan 5, 2026

@shapirov103 functional test added and tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants