fix(lambda): handle NoSuchKey when tagging deleted object#1694
Open
Yashk-15 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1307
Problem
If a file is deleted from S3 mid-scan (after the scan finishes but before the Lambda tags the result),
set_status()callsput_object_tagging()on an object that no longer exists. This raises an unhandledNoSuchKeyClientError, crashing the Lambda instead of failing gracefully.Fix
Wrapped the
put_object_taggingcall inset_status()with the same error-handling pattern already used elsewhere in the file (seeget_status) - catchingNoSuchKey/404specifically and logging it, while still surfacing other unexpected errors as warnings.Testing
Added
test_set_status_put_tagging_nosuchkey, which stubs aNoSuchKeyerror onput_object_taggingand confirmsset_statusno longer raises. Full test suite (25 tests) passes locally.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license