Support custom endpoints and ca bundle path #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 105
Description of changes: This change allows users to set custom endpoints to call EC2 and monitoring (CloudWatch) APIs.
Testing: I've deployed these changes to my personal fleet and verified that the plugin works as expected with and without these overrides. If no override is provided for the EC2 endpoint, the plugin will try to infer it using the existing logic. Same goes for the monitoring endpoint. If no override is provided for the CA bundle path, the plugin will not set a value to
session.verify. The plugin is able to publish the collectd metrics to CloudWatch with and without the endpoint and ca bundle overrides.Also all the existing tests pass, as well as the new ones.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.