Datasets: use HTTPS for uber_tlc download URL - #3290
Open
shaun0927 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: none
Description of changes:
src/gluonts/dataset/repository/_uber_tlc.pystill uses plaintext HTTP to fetch the Uber TLC dataset fromraw.githubusercontent.com. GitHub has served Raw content over HTTPS for years, so the HTTP URL only exists as a 2019-era artifact. Keeping it as HTTP has two downsides:.zipwith an arbitrary payload. The same file is then passed tozipfile.ZipFile.extractallon line 48, so any hostile zip member name that contains..can land files outsidetemp_dir_path.get_dataset("uber_tlc_hourly")fail on installs where every other dataset loader succeeds (those already use HTTPS).This PR flips the single literal to
https://. No other change is needed — GitHub Raw accepts the same path under HTTPS, andurllib.request.urlretrievefollows the scheme as given.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup