fix(pipeline): correct usage for qualifier in diffBucket url #760
Conversation
| )}/s3/buckets/${this.props.prefixes.bucketName}-pipeline-${cdk.Stack.of(this).account}-${ | ||
| cdk.Stack.of(this).region | ||
| }?prefix=AWSAccelerator-Pipel/Diffs/#{codepipeline.PipelineExecutionId}/®ion=${ | ||
| )}/s3/buckets/${this.pipeline.artifactBucket.bucketName}?prefix=AWSAccelerator-Pipel/Diffs/#{codepipeline.PipelineExecutionId}/®ion=${ |
There was a problem hiding this comment.
While I've corrected the incorrect naming of the bucket - the following use of #{codepipeline.PipelineExecutionId} doesn't seem to work (in external deployment account or similar) in this view (likely should go to the service team)
See hyperlink URL bottom of screenshot
But works in this view:
There was a problem hiding this comment.
Great eye, I saw the same behavior but clicking the link still directed me to the correct location in S3.
|
Hey @richardkeit , thanks for submitting this! I was able to reproduce the issue and can confirm it was resolved by your fix, I will merge this code in and make sure its available in our next major release. I will take a look at #754 as well, I am still completing some additional testing there. Thanks for your support of the LZA! |
closes #753
Worth also giving attention to (as I also disabled this to get the external deployment working):