fix: apply global tags to Config Rules and CloudWatch Log Groups #915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issues, #907 & #891
This PR ensures global tags and LZA accelerator tags are consistently applied to AWS Config Rules and CloudWatch Log Groups created by custom resources.
Problem:
Two related tagging issues were identified:
Solution:
This PR implements consistent tagging across both resource types:
Config Rules (#907):
setupConfigServicesTagging()insecurity-resources-stack.tsto include:globalConfig.tagsAccelerator: <prefix>)CloudWatch Log Groups (#891):
SecurityHubEventsLogconstruct to pass tags to custom resourcesecurity-hub-event-loglambda handler to accept and apply tagscreate-log-groupslambda handler to accept and apply tagssecurityHubEventForwardToLogs()to prepare and pass global + accelerator tagsFiles Changed:
security-resources-stack.ts: Config Rules tagging + SecurityHub log group tagssecurity-hub-events-log.ts: Added tags property to interface and passed throughsecurity-hub-event-log/index.ts: Lambda handler accepts and applies tagscreate-log-groups/index.ts: Lambda handler accepts and applies tagsTesting:
Benefits:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.