fix: apply global tags to Config Rules and CloudWatch Log Groups#915
Open
jtaylortech wants to merge 1 commit intoawslabs:release/v1.13.1from
Open
fix: apply global tags to Config Rules and CloudWatch Log Groups#915jtaylortech wants to merge 1 commit intoawslabs:release/v1.13.1from
jtaylortech wants to merge 1 commit intoawslabs:release/v1.13.1from
Conversation
Ensures global tags and LZA accelerator tags are consistently applied to: - AWS Config Rules created in security-resources-stack - CloudWatch Log Groups created by custom resources This closes a security gap where Config Rules lacked LZA tags, making them vulnerable to unauthorized modification via SCP controls. Changes: - Modified setupConfigServicesTagging to include global tags and Accelerator tag - Updated SecurityHubEventsLog to pass tags through to log group creation - Enhanced create-log-groups lambda to accept and apply tags parameter - Enhanced security-hub-event-log lambda to accept and apply tags parameter Fixes awslabs#907 Fixes awslabs#891
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Issues, #907 & #891
This PR ensures global tags and LZA accelerator tags are consistently applied to AWS Config Rules and CloudWatch Log Groups created by custom resources.
Problem:
Two related tagging issues were identified:
Solution:
This PR implements consistent tagging across both resource types:
Config Rules (#907):
setupConfigServicesTagging()insecurity-resources-stack.tsto include:globalConfig.tagsAccelerator: <prefix>)CloudWatch Log Groups (#891):
SecurityHubEventsLogconstruct to pass tags to custom resourcesecurity-hub-event-loglambda handler to accept and apply tagscreate-log-groupslambda handler to accept and apply tagssecurityHubEventForwardToLogs()to prepare and pass global + accelerator tagsFiles Changed:
security-resources-stack.ts: Config Rules tagging + SecurityHub log group tagssecurity-hub-events-log.ts: Added tags property to interface and passed throughsecurity-hub-event-log/index.ts: Lambda handler accepts and applies tagscreate-log-groups/index.ts: Lambda handler accepts and applies tagsTesting:
Benefits:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.