fix(aws-serverless-mcp-server): input validation for startup script generator parameters#2854
Merged
bx9900 merged 2 commits intoawslabs:mainfrom Apr 7, 2026
Merged
fix(aws-serverless-mcp-server): input validation for startup script generator parameters#2854bx9900 merged 2 commits intoawslabs:mainfrom
bx9900 merged 2 commits intoawslabs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2854 +/- ##
=======================================
Coverage 91.37% 91.38%
=======================================
Files 1014 1014
Lines 74953 74973 +20
Branches 12047 12053 +6
=======================================
+ Hits 68491 68511 +20
Misses 3990 3990
Partials 2472 2472 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d6ebd58 to
d7eab32
Compare
bnusunny
approved these changes
Apr 3, 2026
bx9900
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defense-in-depth: Add input validation for
entry_pointandadditional_envparameters in startup script generator. Added allowlist regex validation forentry_pointandshlex.quote()escaping for environment variable values in generated startup scripts. Testing confirmed that arbitrary code execution is not achievable through the intended MCP client interface.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? (Y/N)
N
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.