Skip to content

feat(redshift-mcp-server): add MCP directory requirements (annotations, icon, prompts, support URL)#3520

Open
MD-Mushfiqur123 wants to merge 4 commits into
awslabs:mainfrom
MD-Mushfiqur123:fix/redshift-mcp-directory-requirements
Open

feat(redshift-mcp-server): add MCP directory requirements (annotations, icon, prompts, support URL)#3520
MD-Mushfiqur123 wants to merge 4 commits into
awslabs:mainfrom
MD-Mushfiqur123:fix/redshift-mcp-directory-requirements

Conversation

@MD-Mushfiqur123
Copy link
Copy Markdown

@MD-Mushfiqur123 MD-Mushfiqur123 commented May 14, 2026

Problem

The Anthropic MCP Review Team identified required changes for redshift-mcp-server to be included in the MCP Directory (issue #2484).

Changes

All four requested changes have been implemented:

1. Tool Annotations

Added ToolAnnotations(readOnlyHint=True) to all 6 tools (list_clusters, list_databases, list_schemas, list_tables, list_columns, execute_query) — all are read-only operations.

2. Icon

Added icon.svg — a Redshift-themed database icon (blue gradient cylinder).

3. Prompt Examples

Added 5 practical prompt examples to README:

  • Database Discovery
  • Schema Exploration
  • Column Inspection
  • Data Querying
  • End-to-End Analysis

4. Support URL

Added support = https://github.com/awslabs/mcp/issues to pyproject.toml.

How did you test this code?

  • Verified all tool annotations match the ToolAnnotations pattern used in other servers (aws-pricing-mcp-server, aws-api-mcp-server)
  • icon.svg is a valid SVG readable by browsers
  • README prompt examples follow existing documentation style
  • pyproject.toml follows existing URL conventions

🤖 Agent context

Authored by opencode agent under the direction of @MD-Mushfiqur123. Implementation followed existing patterns in aws-pricing-mcp-server and aws-api-mcp-server for tool annotations. The pyproject.toml URL format follows the existing conventions in the project.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

…s, icon, prompts, support URL)

Adds the changes required by the Anthropic MCP Review Team for redshift-mcp-server directory inclusion:

- Tool annotations: Added ToolAnnotations(readOnlyHint=True) to all 6 tools
- Icon: Added icon.svg with Redshift-themed database icon
- Prompt examples: Added 5 practical prompt examples to README
- Support URL: Added support link pointing to repo issues page
Copy link
Copy Markdown

@Mattral Mattral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there, I'm trying to learn something from your PR, Thank you for aligning this with the MCP Directory requirements. One question: since tools are marked read‑only, how do you envision handling future Redshift operations that might require write or admin actions; would those be separate tools or annotated differently? Clarifying this now could help maintainers keep consistency across servers.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use an official redshift icon instead https://awsfundamentals.com/aws-icons/amazon-redshift.

Comment thread src/redshift-mcp-server/README.md Outdated
}
```

## Prompt Examples
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a Basic Usage section earlier in this file. I would accept it to be renamed as Prompt Examples and enriched with the prompt examples you provided below considering the steuctural alignment (yours is fine).

@grayhemp grayhemp assigned grayhemp and MD-Mushfiqur123 and unassigned grayhemp May 14, 2026
@MD-Mushfiqur123
Copy link
Copy Markdown
Author

I have addressed the requested changes:

  1. Updated icon.svg to use the official Amazon Redshift icon.
  2. Refactored README.md by renaming 'Basic Usage' to 'Prompt Examples' and integrating the provided prompt examples into that section, while also removing duplicate sections.

@Mattral regarding your question: future write or admin operations will be implemented as separate tools and will be annotated accordingly (e.g.,
eadOnlyHint=False) to maintain a clear distinction between read-only and write operations for safety and consistency.

@MD-Mushfiqur123 MD-Mushfiqur123 requested a review from grayhemp May 14, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To triage

Development

Successfully merging this pull request may close these issues.

3 participants