CW logging workaround#167
Merged
Merged
Conversation
…t config - serve template: skip args with value "false", emit flag-only for "true" - endpoint-config.sh: add RoutingConfig with LEAST_OUTSTANDING_REQUESTS for IC-based endpoints (required for IC scheduler placement) - notebook-export tests: remove trailing commas, use arrow functions
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two deployment issues and cleans up test linting.
Changes
Boolean env var handling (
templates/code/serve)Environment variables with value
"false"were being passed as--flag falseto model servers. Now
falseskips the arg entirely, andtrueemits aflag-only arg (no value). This matches how vLLM/SGLang interpret boolean flags.
RoutingConfig for IC endpoints (
templates/do/lib/endpoint-config.sh)IC-based endpoints require
RoutingConfigin the production variant. Without it,the IC scheduler cannot place containers and the IC stays in
Creatingwith nologs. Adds
LEAST_OUTSTANDING_REQUESTSrouting strategy.Test lint fixes (
test/property/notebook-export.property.test.js)Removes trailing commas and converts
function()to arrow functions to satisfyESLint rules.
Testing