feat: support deploying the node DaemonSet with hostNetwork enabled#573
Open
rodrigorfk wants to merge 1 commit into
Open
feat: support deploying the node DaemonSet with hostNetwork enabled#573rodrigorfk wants to merge 1 commit into
rodrigorfk wants to merge 1 commit into
Conversation
rodrigorfk
had a problem deploying
to
approval-gate
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Currently, the helm chart does not allow changing the the
hostNetworkconfiguration for the node DaemonSet and for certain use cases, it will be interesting to do so as many users running EKS clusters with standard amazon-vpc-cni setups are keen to reduce the amount of IPs needed by DaemonSets, a common practices in this case is to enablehostNetworkmode for trustworthy daemons. As a side requirement of that, users might have to change the port where the healthzliveness-probecontainer is running, so it will avoid conflicts with other daemons listening on the same port, for example the https://github.com/kubernetes-sigs/aws-ebs-csi-driver also listens on the default9808port.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.