Update usages of GPG public keys with new rotated key#754
Merged
Conversation
renanmagagnin
had a problem deploying
to
approval-gate
GitHub Actions
Failure
Signed-off-by: Renan Magagnin <renanmag@amazon.co.uk>
renanmagagnin
force-pushed
the
add-new-release-gpg-key
branch
from
d926fef to
c9c8f42
Compare
renanmagagnin
had a problem deploying
to
approval-gate
GitHub Actions
Failure
yerzhan7
approved these changes
Mar 20, 2026
jet-tong
reviewed
Mar 23, 2026
| # Import the key and validate it has the fingerprints we expect | ||
| RUN gpg --import KEYS && \ | ||
| (gpg --fingerprint mountpoint-s3@amazon.com | grep "673F E406 1506 BB46 9A0E F857 BE39 7A52 B086 DA5A") | ||
| (gpg --fingerprint mountpoint-s3@amazon.com | grep "8AEF E705 EBE3 29C0 948C 75A6 6F1C 3B3A EF4B 030B") && \ |
Collaborator
There was a problem hiding this comment.
QQ: why are we using &&? Since we're rotating the GPG keys not adding a new one, perhaps this should be || ? (or that we have 2 keys in transition period?)
renanmagagnin
had a problem deploying
to
approval-gate
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: We have a new GPG public key because the old one will expire soon. In this PR we update the usages of the public keys with the new one.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.